[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbca3e24139cc: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/DraftStore.cpp:66 // We treat versions as opaque, but the protocol says they increase. -if (*Version <= D.Vers

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

sammccall added a comment. In D97738#2597296 , @kadircet wrote: > as discussed offline, i am hesitant about `validateEdits` layering at the > moment. but i suppose the best thing to do is move it into clangdserver and > expose a structrual api, as you pr

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

sammccall updated this revision to Diff 327481. sammccall marked 3 inline comments as done. sammccall added a comment. address comments remove one more redundant getDraft() check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97738/new/ https://revi

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

kadircet added a comment. as discussed offline, i am hesitant about `validateEdits` layering at the moment. but i suppose the best thing to do is move it into clangdserver and expose a structrual api, as you proposed, which can be done independently. Comment at: clang-tools-e

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

sammccall created this revision. sammccall added reviewers: njames93, kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. ClangdServer already gets notifi