[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

This revision was automatically updated to reflect the committed changes. Closed by commit rG68d133a3e8c9: [OpenMP] Simplify GPU memory globalization (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D97680?vs=347097&id=353650#toc Repository: rG LLVM Github Monorepo C

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 _

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 347097. jhuber6 added a comment. Fixing nits and splitting command line removal to a new patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files: clang/lib/CodeG

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Generally LGTM. Some nits. Comment at: clang/include/clang/Driver/Options.td:2331 PosFlag, NegFlag, BothFlags<[NoArgumentUnused, HelpHidden]>>; -def fopenmp_cuda_parallel_target_regions : Flag<["-"], "fopenmp-cuda-parallel-target-regions">,

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 345557. jhuber6 edited the summary of this revision. jhuber6 added a comment. Splitting patches into D97680 and D102532 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 344538. jhuber6 added a comment. Fixing tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files: clang/include/clang/Basic/LangOptions.def clang/include/

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Is it better to split the patch? For example, the new alloc/free shared can be in a separate patch, and the globalization can be in another one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://revie

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 343469. jhuber6 added a comment. Rebasing. The previous change to the test files required massive changes that made the file size too big to upload, so context is limited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

josemonsalve2 added inline comments. Comment at: clang/test/OpenMP/nvptx_parallel_codegen.cpp:4 -// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s -fopenmp-is-device -fopenmp-host-ir-file-path %t-ppc-ho

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 330352. jhuber6 added a comment. Herald added a subscriber: ormris. Changed the RTL to have an argument that indicates if there is only one active caller for a team. This makes it easier to optimize. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/src/data_sharing.cu:34 +EXTERN void *__kmpc_alloc_shared(size_t DataSize) { + return (void *)SafeMalloc(DataSize, "Alloc Shared"); } Add a TODO: 1) Use a small shared buffer 2) e

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 added a comment. Fixing tests is WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: LLVM, clang, OpenMP. Herald added subscribers: jfb, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. M