This revision was automatically updated to reflect the committed changes.
Closed by commit rGbad8e577f9c7: Fix DecisionForestBenchmark.cpp compile errors
(authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97620/new/
https://revie
poelmanc marked an inline comment as done.
poelmanc added a comment.
Fixed comment as requested (keys()->size().) I don't have commit access so if
you can push it that would be great, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97620/new/
https://reviews.llvm.org/D97620
poelmanc updated this revision to Diff 327174.
poelmanc added a comment.
Fix comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97620/new/
https://reviews.llvm.org/D97620
Files:
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp
Index:
clang-tools
usaxena95 accepted this revision.
usaxena95 added a comment.
This revision is now accepted and ready to land.
LG. Thanks for noticing and fixing it!
Comment at:
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:41
E.setSymbolCategory(RandInt(
poelmanc updated this revision to Diff 326937.
poelmanc added a comment.
Shorten comment and add period.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97620/new/
https://reviews.llvm.org/D97620
Files:
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp
poelmanc created this revision.
poelmanc added a reviewer: usaxena95.
poelmanc added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
poelmanc requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang.
clang-to
