[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

2021-03-02 Thread Sam McCall via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rG91679c95bbed: [clangd]

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

2021-03-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks, LGTM. with a couple nits and asking for some extra clarifications :) Comment at: clang-tools-extra/clangd/FindSymbols.cpp:283 + public: +SymBuilder() = default; + nit: drop this one? Comment at: clang-to

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

2021-02-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Before: F15668515: 2021-02-27-141552_903x356_scrot.png After: F15668516: 2021-02-27-141523_815x430_scrot.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

2021-02-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Browsing macro-generated symbols is confu