[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

2021-07-28 Thread Jessica Clarke via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40080e7e7f42: [Clang interpreter] Avoid storing pointers at unaligned locations (authored by jrtc27). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

2021-03-03 Thread Nandor Licker via Phabricator via cfe-commits
nand added a comment. The patches implementing more features/control flow constructs have not yet been committed, so if the pre-existing test passes, the functionality should be fine. Adjustments can be made later on when those patches are rebased. Comment at: clang/lib/AST/I

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

2021-02-26 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Is there any way I can usefully test this? As far as I can tell there's only a single constexpr test in the tree that uses the new interpreter, and it's pretty trivial? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97606/ne

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

2021-02-26 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 updated this revision to Diff 326872. jrtc27 added a comment. Reworked code slightly to make it look nicer after clang-format uglified it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97606/new/ https://reviews.llvm.org/D97606 Files: clan

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

2021-02-26 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 created this revision. jrtc27 added reviewers: nand, jfb, Bigcheese, rsmith, dexonsmith. Herald added subscribers: kristof.beyls, arichardson. jrtc27 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang interpreter's bytecode us