[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT abandoned this revision. oToToT added a comment. Since, originally, I think it is OK to submit patch just by project, but I agree that it's better to make patch as minimal as possible. Thus, I will abandon this and resubmit another patch. (I think reuploading patch and changing the whole p

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

sammccall added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1153 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); This part is not used by clan

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added a comment. Kindly ping. Since the part I modified is quite... old (about 4 to 7 years ago?), I hope I've found the right person to review for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97561/new/ https://reviews.llvm.org/D97

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:368 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); - if (!Clang->hasTarget()) + if (!Cl

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, klimek, dexonsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As proposed in D97109 , I tried to replace all similar tar