[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet abandoned this revision. kadircet added a comment. > Is this entirely obsoleted by the approach in D98499 > ? yes it is! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97555/new/ https://reviews.llvm.org/D

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

sammccall added a comment. Herald added a project: clang-tools-extra. Is this entirely obsoleted by the approach in D98499 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97555/new/ https://reviews.llvm.org/D97555

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Module.h:97 + /// Called by auxilary threads as diagnostics encountered to generate fixes. + /// So this can be called concurrently from multiple threads. If a module sammccall wrote: > This

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Module.h:97 + /// Called by auxilary threads as diagnostics encountered to generate fixes. + /// So this can be called concurrently from multiple threads. If a module This seems too special

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97555/new/ https://reviews.llvm.org/D97555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D96245