This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG523d7bc6f427: [flang][driver] Add `-fdebug-dump-parsing-log`
(authored by awarzynski).
Changed prior to commit:
https://reviews.llvm.org/D97457?vs
awarzynski updated this revision to Diff 328970.
awarzynski added a comment.
Generalise the test so that it's not architecture specific
I've just realised that the test was failing in Phabricator's CI. It turns out
it's an X86-only failure (i.e. the test works fine on my AArch64 dev machine).
T
ashermancinelli added a comment.
It //is// unintuitive to me that we are mixing feature and action flags,
however I don't have a better suggestion. LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97457/new/
https://reviews.llvm.org/D97457
___
arnamoy10 added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97457/new/
https://reviews.llvm.org/D97457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
AMDChirag added a comment.
LGTM.
I'll let someone else review the patch if required.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97457/new/
https://reviews.llvm.org/D97457
___
cfe-commits mailing list
awarzynski added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95
+// Tweak the frontend configuration based on the frontend action
+static void setUpFrontendBasedOnAction(FrontendOptions &opts) {
+ assert(opts.programAction_ != Fortran::frontend::Inv
awarzynski updated this revision to Diff 327048.
awarzynski marked an inline comment as done.
awarzynski added a comment.
Move the call to setUpFrontendBasedOnAction after all options have been set
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97457
AMDChirag added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95
+// Tweak the frontend configuration based on the frontend action
+static void setUpFrontendBasedOnAction(FrontendOptions &opts) {
+ assert(opts.programAction_ != Fortran::frontend::Inva
awarzynski marked an inline comment as done.
awarzynski added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95
+// Tweak the frontend configuration based on the frontend action
+static void setUpFrontendBasedOnAction(FrontendOptions &opts) {
+ assert(
awarzynski updated this revision to Diff 326372.
awarzynski added a comment.
Remove spurious comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97457/new/
https://reviews.llvm.org/D97457
Files:
clang/include/clang/Driver/Options.td
flang/i
AMDChirag added inline comments.
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95
+// Tweak the frontend configuration based on the frontend action
+static void setUpFrontendBasedOnAction(FrontendOptions &opts) {
+ assert(opts.programAction_ != Fortran::frontend::Inva
awarzynski created this revision.
Herald added a reviewer: sscalpone.
Herald added subscribers: jansvoboda11, dang.
awarzynski requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Adds `-fdebug-dump-parsing-log` in the new driver. This option is
12 matches
Mail list logo
