[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. In D97361#2609616 , @nullptr.cpp wrote: > - Restrict to only run on C++ code > - Ignore `using` defined in macro > - Support inline namespace > - Support global namespace Ping. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 331188. nullptr.cpp retitled this revision from "[clang-tidy] Add cppcoreguidelines-comparison-operator" to "[clang-tidy] Add readability-redundant-using check". nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Rebase Repos

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Herald added a project: clang-tools-extra. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-comm

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 328841. nullptr.cpp added a comment. - Restrict to only run on C++ code - Ignore `using` defined in macro - Support inline namespace - Support global namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

Eugene.Zelenko added a comment. In D97361#2589673 , @balazske wrote: > You can look into **misc/UnusedUsingDeclsCheck.cpp** (if not done yet), that > check handles `using` too. And that check is related to this check, the > module should be the same too

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added a comment. There should be already a name lookup implemented somewhere in clang (`DeclContext`? or Sema) that maybe usable here (check if the name of the "used" entity is visible in the declaration context of the `using` statement). Probably it is not as simple to do because the

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added a comment. You can look into **misc/UnusedUsingDeclsCheck.cpp** (if not done yet), that check handles `using` too. And that check is related to this check, the module should be the same too (`misc`)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

njames93 added a comment. Can you override the `isLanguageVersionSupported` method to ensure this check only runs over c++ code. Can you add some macro tests, typically we err on the side of caution and don't emit any fixes for macro code. You can use `SourceLocation::IsMacroID()` to detect mac

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-using.cpp:114 +// CHECK-FIXES: {{^}} +} // namespace n11 Add more tests? ``` namespace outer { namespace inner { void func(); } // namespace inner using

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 326320. nullptr.cpp retitled this revision from "[clang-tidy] Add misc-redundant-using check" to "[clang-tidy] Add readability-redundant-using check". nullptr.cpp added a comment. Modify according to suggestions Repository: rG LLVM Github Monorepo CH