[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

xiangzhangllvm added a comment. +1 first, didn't see key problems. Comment at: clang/lib/Headers/amxintrin.h:326 +__DEFAULT_FN_ATTRS_BF16 +static void __tile_tdpbf16ps(__tile1024i *dst, __tile1024i src1, + __tile1024i src2) { yubing

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

yubing added inline comments. Comment at: clang/lib/Headers/amxintrin.h:326 +__DEFAULT_FN_ATTRS_BF16 +static void __tile_tdpbf16ps(__tile1024i *dst, __tile1024i src1, + __tile1024i src2) { Should we align this with "tile_dpbssd" by ren

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bc7c8631ad6: [X86] Support amx-bf16 intrinsic. (authored by LiuChen3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 added a comment. I don't know why pre-merge-checks failed. I can check-all successfully locally in redhat8. I don't have debian mainchine to reproduce this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews.llvm.org/D97358 __

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 updated this revision to Diff 326002. LiuChen3 added a comment. Address Pengfei and Yuanke's comments. We don't need more tile type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews.llvm.org/D97358 Files: clang/i

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; LiuChen3 wrote: > LuoYuanke wrote: > > pengfei wrote: > > > Is there much value to differentiate the type? We are usin

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; LuoYuanke wrote: > pengfei wrote: > > Is there much value to differentiate the type? We are using the same AMX > > t

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LuoYuanke added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; pengfei wrote: > Is there much value to differentiate the type? We are using the same AMX type > in the builtins. W

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; Is there much value to differentiate the type? We are using the same AMX type in the builtins. What do you think? @Lu

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 updated this revision to Diff 325988. LiuChen3 added a comment. Adding back 'avx512f' to amx-tile-basic.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews.llvm.org/D97358 Files: clang/include/clang/Basic/Builtin

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 created this revision. Herald added subscribers: pengfei, hiraditya. LiuChen3 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adding support for intrinsics of AMX-BF16. This patch alse fix a bug that AMX-INT8 inst