[PATCH] D97340: [HIP] Support Spack packages

yaxunl added a comment. opened https://reviews.llvm.org/D103281 to fix device lib detection for spack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 ___ cfe-comm

[PATCH] D97340: [HIP] Support Spack packages

yaxunl added a comment. In D97340#2778073 , @haampie wrote: > Hi Yaxunl, > >> The patch should not cause circular dependency on HIP or device library. > > I'm not saying this patch introduces a circular dependency, I'm saying you > are trying to solve an

[PATCH] D97340: [HIP] Support Spack packages

haampie added a comment. Herald added a subscriber: foad. Hi Yaxunl, > The patch should not cause circular dependency on HIP or device library. I'm not saying this patch introduces a circular dependency, I'm saying you are trying to solve an already existing circular dependency (clang needs dev

[PATCH] D97340: [HIP] Support Spack packages

yaxunl added a comment. In D97340#2775477 , @haampie wrote: > Hi @tra and @yaxunl, I'm commenting as a reviewer of the spack pull request > for the rocm 4.2.0 ecosystem. First of all: thanks for caring about spack > installations, that's highly appreciat

[PATCH] D97340: [HIP] Support Spack packages

haampie reopened this revision. haampie added a comment. This revision is now accepted and ready to land. I've created a pull request to spack here: https://github.com/spack/spack/pull/23859, hopefully that's enough to revert this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D97340: [HIP] Support Spack packages

haampie added a comment. Herald added a subscriber: ormris. Hi @tra and @yaxunl, I'm commenting as a reviewer of the spack pull request for the rocm 4.2.0 ecosystem. First of all: thanks for caring about spack installations, that's highly appreciated. However, this patch does not seem the right

[PATCH] D97340: [HIP] Support Spack packages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 4 inline comments as done. Closed by commit rG34d1a5c7b18f: [HIP] Support Spack packages (authored by yaxunl). Herald added a project: clang. Changed pri

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:163 // For candidate specified by --rocm-path we do not do strict check. +const SmallVectorImpl & tra wrote: > I'm not quite sure which pa

[PATCH] D97340: [HIP] Support Spack packages

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM modulo couple of nits. Comment at: clang/include/clang/Driver/Options.td:3535-3536 HelpText<"Print the registered targets">; +def print_rocm_search_dirs : Flag<["-", "--"],

[PATCH] D97340: [HIP] Support Spack packages

yaxunl updated this revision to Diff 327596. yaxunl marked 5 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 HelpText<"Print the registered targets">; +def print_rocm_search_dirs : Flag<["-", "--"], "print-rocm-search-dirs">, + HelpText<"Print the paths

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 HelpText<"Print the registered targets">; +def print_rocm_search_dirs : Flag<["-", "--"], "print-rocm-search-dirs">, + HelpText<"Print the paths used for finding ROCm installation">; def p

[PATCH] D97340: [HIP] Support Spack packages

yaxunl updated this revision to Diff 327243. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:32 +static llvm::SmallString<0> findSPACKPackage(const Driver &D, + const llvm::SmallString<0> &Path, +

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:32 +static llvm::SmallString<0> findSPACKPackage(const Driver &D, + const llvm::SmallString<0> &Path, + StringRef

[PATCH] D97340: [HIP] Support Spack packages

yaxunl updated this revision to Diff 326254. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:25-31 +// Look for sub-directory starts with Prefix under Path. If there is one and +// only one matching sub-directory found, append the sub-directory to Pat

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:25-31 +// Look for sub-directory starts with Prefix under Path. If there is one and +// only one matching sub-directory found, append the sub-directory to Path. If +// there is no matching sub-directory

[PATCH] D97340: [HIP] Support Spack packages

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: jansvoboda11, dang, kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Spack is a package management tool extensively used by HPC community. As ROCm packages are built by Spack by HPC community