[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

2021-02-23 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D97324#2583286 , @jyknight wrote: > I can imagine there being some cases where these could theoretically be > useful. > > But if you've tested this change and it doesn't cause build failures with any > existing uses of Trai

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

2021-02-23 Thread Erich Keane via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4451eb4f38: [NFC] Make TrailingObjects non-copyable/non-movable (authored by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

2021-02-23 Thread James Y Knight via Phabricator via cfe-commits
jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. I can imagine there being some cases where these could theoretically be useful. But if you've tested this change and it doesn't cause build failures with any existing uses of TrailingObjec

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

2021-02-23 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: jyknight, jfb, hubert.reinterpretcast. Herald added a subscriber: dexonsmith. erichkeane requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This got me pretty recently... TrailingOb