[PATCH] D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status()

dexonsmith added a comment. If we do add this, I'd suggest a separate function rather than modifying the current one. I also think implementing it should be optional. Something like: virtual ErrorOr status(const Twine &Path) = 0; virtual ErrorOr status(const Twine &Path, bool FollowSymlinks)

[PATCH] D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status()

alexfh added a comment. In D97288#2581908 , @sammccall wrote: > How strong is the need for this? > This adds complexity to a widely implemented and used interface, and the > combination of virtual + default parameters can be at least a little > confusing

[PATCH] D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status()

sammccall added a comment. How strong is the need for this? This adds complexity to a widely implemented and used interface, and the combination of virtual + default parameters can be at least a little confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status()

alexfh created this revision. alexfh added a reviewer: sammccall. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. alexfh requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Currently, status() calls always