This revision was automatically updated to reflect the committed changes.
Closed by commit rG99951aa68da3: OpenMP: Fix object clobbering issue when using
save-temps (authored by pdhaliwal).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97273/new/
ht
JonChesterfield added a comment.
Works everywhere we have tried it. Fundamentally it renames a temporary file,
so shouldn't break much. Will be great to have -save-temps working for nvptx.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97273/new/
h
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM, assuming it doesn't break support the reasoning makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97273/new/
https://review
pdhaliwal added a comment.
Here's a bit of background,
OffloadingPrefix was not getting properly set in the dependent actions of
OffloadWrapperJobAction (which are backend [11] and assemble [12]). Since
backend [11] and assemble [12] host-wrapper actions have same logic to the
other host action
pdhaliwal created this revision.
pdhaliwal added reviewers: jdoerfert, JonChesterfield, ronlieb, tianshilei1992.
Herald added subscribers: guansong, yaxunl.
pdhaliwal requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
There are two pr
