[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

2021-03-01 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D97158#2594973 , @njames93 wrote: > Should we make `nullPtrConstant()` a top level mather? I feel like this > change would actually throw users off. This would make this matcher a "convenience" matcher. https://reviews.llvm.

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

2021-03-01 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Should we make `nullPtrConstant()` a top level mather? I feel like this change would actually throw users off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97158/new/ https://reviews.llvm.org/D97158

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

2021-02-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 325398. steveire added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97158/new/ https://reviews.llvm.org/D97158 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AS

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

2021-02-21 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Won't this change require a regeneration of the documentation `clang/docs/tools/dump_ast_matchers.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97158/new/ https://reviews.llvm.org/D97158 _

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

2021-02-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97158 Files: clang/include/clang