[PATCH] D97156: [ASTMatchers] Make Param functors variadic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG243cd0afadc7: [ASTMatchers] Make Param functors variadic (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, assuming none of the later changes have effected the documentation script. In D97156#2598398 , @steveire wrote: > In D97156#2593209

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire added a comment. In D97156#2593209 , @njames93 wrote: > Is it not nicer to name the class `PolymorphicMatcher` and do away with > `WithParamN`, It may require partial specialization for the empty parameters > case. > But I think it would be wort

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire updated this revision to Diff 327559. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 Files: clang/docs/tools/dump_ast_matchers.py clang/include/clang/ASTMatche

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

njames93 added a comment. Is it not nicer to name the class `PolymorphicMatcher` and do away with `WithParamN`, It may require partial specialization for the empty parameters case. But I think it would be worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire added a comment. Good catch! Updated the docs generating script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 ___ cfe-commits mailing list cfe-commits

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire updated this revision to Diff 325409. steveire added a comment. Update dump script Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 Files: clang/docs/tools/dump_ast_matchers.py clang/include/cla

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

njames93 added a reviewer: klimek. njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. This change is going to break the dump_ast_matchers script. So that will need updating to ensure everything is all correct. Repository: rG L

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire updated this revision to Diff 325319. steveire added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/includ

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire added a comment. This was part of an early attempt to implement `mapAnyOf`. It's not needed, but it seems like a better idea to have one variadic class than multiple Param1/2 classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/ne

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97156 Files: clang/include/clang