This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7b6fc9a1055a: [clang-tidy] Simplify unused RAII check
(authored by stephenkelly).
Changed prior to commit:
https://reviews.llvm.org/D97142?vs=3270
njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.
LG, with 1 nit.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone-unused-raii.cpp:81-82
+
+ int i = 0;
+ (void)i;
+}
Is this necessary?
steveire updated this revision to Diff 327004.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97142/new/
https://reviews.llvm.org/D97142
Files:
clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp
clang-too
njames93 added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone-unused-raii.cpp:49-53
+struct CtorDefaultArg {
+ CtorDefaultArg(int i = 0);
+ ~CtorDefaultArg();
+};
+
Its not obvious from the code, but this should work if there
steveire created this revision.
steveire added reviewers: aaron.ballman, njames93.
Herald added a subscriber: xazax.hun.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fix handling of default construction where the constructor has
