[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad14ccc8c22e: [clang][flang] Improve the consistency of the code-base (authored by achieveartificialintelligence). Repository: rG LLVM Github Mono

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you, this is a much appreciated improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ https://reviews.llvm.org/D97138 __

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

aganea accepted this revision. aganea added a comment. In D97138#2586988 , @achieveartificialintelligence wrote: > Thanks @aganea. And I have a question that, should I use `argc` & `argv` or > `argC` & `argV` in the flang part now ? Looks good as it is

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks @aganea. And I have a question that, should I use `argc` & `argv` or `argC` & `argV` in the flang part now ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ ht

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence updated this revision to Diff 326313. achieveartificialintelligence edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ https://reviews.llvm.org/D97138 Files: clang/tools/driver/driver.cpp flang/tools/flang-drive

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:349 "source, and associated run script.\n"); - SmallVector argv(argv_, argv_ + argc_); + SmallVector ArgValues(Argv, Argv + Argc); What about just `Args`? "Values

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence added a comment. In D97138#2578563 , @awarzynski wrote: > Thank you for submitting this @achieveartificialintelligence ! > > The aim of these changes is to improve the consistency of the code-base with > respect to the coding

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence updated this revision to Diff 325609. achieveartificialintelligence retitled this revision from "[Driver] replace argc_ with argc" to "[clang][flang] Improve the consistency of the code-base". achieveartificialintelligence edited the summary of this revision. achievea