[PATCH] D97138: [Driver] replace argc_ with argc

2021-02-22 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski requested changes to this revision. awarzynski added a comment. This revision now requires changes to proceed. Thank you for submitting this @achieveartificialintelligence ! The aim of these changes is to improve the consistency of the code-base with respect to the coding standards do

[PATCH] D97138: [Driver] replace argc_ with argc

2021-02-22 Thread James Henderson via Phabricator via cfe-commits
jhenderson resigned from this revision. jhenderson added a comment. In general, I don't work on the clang side. As such, I don't know the norms surrounding this sort of change in this area, and don't feel comfortable reviewing. You should look at getting reviewers who do work in that part of the

[PATCH] D97138: [Driver] replace argc_ with argc

2021-02-21 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: MaskRay, jhenderson, aganea, richard.barton.arm, sameeranjoshi. Herald added a reviewer: awarzynski. achieveartificialintelligence requested review of this revision. Herald added a project: clang. H