[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was automatically updated to reflect the committed changes. Closed by commit rGf60b35340fd7: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.or

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. In D97125#2603832 , @thopre wrote: > Requesting review since the logic has changed. This time I've also tested > isfinite against glibc's result. All looks good. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre requested review of this revision. thopre added a comment. Requesting review since the logic has changed. This time I've also tested isfinite against glibc's result. All looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ h

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328171. thopre added a comment. Add isfinite testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328170. thopre added a comment. Fix isfinite logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/stri

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b6eb56aa0ea: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. Ping? Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT: [[IFL

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added inline comments. Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT: [[IFLOA

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 325718. thopre added a comment. - Add half testcase - Fixup existing testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

jonpa added a comment. In D97125#2578853 , @kpn wrote: > System/Z's TEST DATA CLASS instruction covers most (all?) of the possible FP > value states. You might want to subscribe, or add as a reviewer, jonpa just > to make sure everyone stays in sync. Th

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. I think we should also add tests for half Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

kpn added a comment. System/Z's TEST DATA CLASS instruction covers most (all?) of the possible FP value states. You might want to subscribe, or add as a reviewer, jonpa just to make sure everyone stays in sync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre created this revision. thopre added reviewers: kpn, efriedma, mibintc, sepavloff, rjmccall. Herald added a subscriber: pengfei. thopre requested review of this revision. Herald added a project: clang. __builtin_isinf currently generates a floating-point compare operation which triggers a tr