[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rGb859c39c40a7: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 423230. njames93 added a comment. Added clangd release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

aaron.ballman added a comment. In D97121#3452435 , @njames93 wrote: > In D97121#3448467 , @aaron.ballman > wrote: > >> I'd like to hear from @sammccall as well, but I think the changes here LGTM. >> Can you please

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 added a comment. In D97121#3448467 , @aaron.ballman wrote: > I'd like to hear from @sammccall as well, but I think the changes here LGTM. > Can you please add a release note for the fix? Is this a clang-tidy, clangd or both release notes. The c

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! (I'm sorry, somehow I had misunderstood what this patch was about, and wasn't paying attention) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

aaron.ballman added a comment. I'd like to hear from @sammccall as well, but I think the changes here LGTM. Can you please add a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 __

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 421310. njames93 added a comment. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tidy/ClangTidyCh

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 396219. njames93 added a comment. Herald added a subscriber: carlosgalvezp. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tid

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 341167. njames93 added a comment. Rebase and fix up new checks added and changes to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/c

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

steveire added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp:285 +#include "path/to/header2.h" +#include "path/to/header.h" + njames93 wrote: > steveire wrote: > > I still find it really confusing that the "single ins

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 331023. njames93 added a comment. Turns out we don't need to worry about InsertedHeaders at all in IncludeInserter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Fi

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 330511. njames93 added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-tools-extra/cl

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:217 bool AllowEnablingAnalyzerAlphaCheckers; + bool SelfContainedDiags; }; steveire wrote: > The order of member

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

steveire added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:178 + void setSelfContainedDiags(bool Value = true) { SelfContainedDiags = Value; } +