[PATCH] D97119: [flang][driver] Add options for -std=2018

2021-02-26 Thread Arnamoy B via Phabricator via cfe-commits
arnamoy10 updated this revision to Diff 326760. arnamoy10 added a comment. 1. Updated the test case to include a check when the option is not given and make sure works with f18 as well (with `Mstandard`) 2. Changed variable names as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D97119: [flang][driver] Add options for -std=2018

2021-02-22 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Hi @arnamoy10 , thank for working on this! I suggest making it more explicit that the new option is about _enabling standard conformance checks_. So e.g. `enableConformanceChecks` rather than `setStandard` (or `set_EnableConformanceChecks` if the member variable is

[PATCH] D97119: [flang][driver] Add options for -std=2018

2021-02-20 Thread Tim Keith via Phabricator via cfe-commits
tskeith added a comment. Please make sure the test works with f18 also. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:294 +// We only allow 2018 as the given standard +if (standard.equals("2018")) { + res.SetStandard(); This should be "f201

[PATCH] D97119: [flang][driver] Add options for -std=2018

2021-02-20 Thread Arnamoy B via Phabricator via cfe-commits
arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, clementval, tskeith. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for the following Fo