[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. In D97068#2617751 , @jroelofs wrote: > In D97068#2617642 , @ggeorgakoudis > wrote: > >> Add triple to avoid spurious failures in tests > > They're not really spurious, right... Doesn'

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs added a comment. In D97068#2617642 , @ggeorgakoudis wrote: > Add triple to avoid spurious failures in tests They're not really spurious, right... Doesn't this mean that `utils/update_cc_test_checks.py` is now broken for people who develop on a

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2abe2259c2d: Run non-filechecked commands in update_cc_test_checks.py (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis updated this revision to Diff 329734. ggeorgakoudis added a comment. Add triple to avoid spurious failures in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.org/D97068 Files: clang/test/utils/up

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. @jroelofs, thank you very much for the much useful information. I will try to replicate the problem with the apple triple and fix it, if possible, or otherwise use your patch to avoid the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs reopened this revision. jroelofs added a comment. This revision is now accepted and ready to land. Reverted in a24644bb1ce09b40c2d751569dd5bb37ea9c995d to get the bots green again. Feel free to re-land with a fix. R

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs added a comment. In D97068#2611696 , @ggeorgakoudis wrote: > In D97068#2611269 , @thakis wrote: > >> Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt >> >> Please take a look,

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

arichardson added a comment. IMO this should also handle the %t substitution and create a temporary directory. Otherwise we end up writing files to whatever the current cwd is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://revie

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. In D97068#2611269 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt > > Please take a look, and revert for now if it takes a while to fix. Hey @thakis, it should be an easy fix.

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60d4c73b30a0: Run non-filechecked commands in update_cc_test_checks.py (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.org/D97068 ___

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis updated this revision to Diff 328887. ggeorgakoudis added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update implementation to support running non-clang runlines, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http