[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25ad188bfcdb: [OpenCL] Prevent adding extension pragma by default. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 ___ cfe-comm

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 327400. Anastasia added a comment. Reuploaded with changes from the 1st review round. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/include

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. Thanks for working on this. LGTM in general. I'll let Marco comment on the latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 ___ cfe-commits mailing list cfe-c

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added a comment. In D97052#2587043 , @azabaznov wrote: > I see the update regaring this functionality on github issue: > https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. > Is it a right way to reflect this informati

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 327204. Anastasia added a comment. - Reorder fields, - make constructor parameters explicit - use `insert_or_assign` member of `StringMap`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/in

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. I see the update regaring this functionality on github issue: https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. Is it a right way to reflect this information in`OpenCLExtensions.def`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) Anastasia wrote: > azabaznov wrote: > > A

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini added a comment. Some relatively minor comments, overall direction seems good to me. Comment at: clang/include/clang/Basic/OpenCLOptions.h:67 public: struct OpenCLOptionInfo { // Option starts to be available in this OpenCL version In OpenCL

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 325734. Anastasia added a comment. Fixed typo and extra space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/include/clang/Basic/OpenCLOpti

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > Anastasia wrote: > > a

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) Anastasia wrote: > azabaznov wrote: > > I

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > I think core and optio

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) I think core and optional core features d

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:24 +//its behavior explicitly is deprecated. Therefore the default +//value if false. // avail - minimum OpenCL version supporting it. typo =

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. Thanks! I review is shortly. As for now, I also was doing some refactoring: https://reviews.llvm.org/D97058. Check-clang passes, as I see there are no conflicts for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia created this revision. Anastasia added reviewers: azabaznov, svenvh, mantognini. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. Currently, extension pragma is always added when new OpenCL option (extension or feature) is added to the fronten