[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

2021-02-23 Thread Sven van Haastregt via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG612d0ef1732f: [OpenCL] Move remaining defines to opencl-c-base.h (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D96948?vs

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

2021-02-19 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. In D96948#257 , @Anastasia wrote: > LGTM! Btw since we are moving this code anyway, do you think we could fix the > formatting? Sure, I'll do that before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

2021-02-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Btw since we are moving this code anyway, do you think we could fix the formatting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

2021-02-18 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Move any remaining preprocessor defines from `opencl-c.h` to `opencl-c-base.h`, such