[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a8589e5d2f: [clang][RecoveryAST] Add design doc to clang internal manual. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96944/new/ h

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

kadircet accepted this revision. kadircet added inline comments. Comment at: clang/docs/InternalsManual.rst:1882 + example. +- representing invalid node: the invalid node is preserved in the AST in some + form, e.g. when the "declaration" part of the declaration contains semant

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

hokein added inline comments. Comment at: clang/docs/InternalsManual.rst:1882 + example. +- representing invalid node: the invalid node is preserved in the AST in some + form, e.g. when the "declaration" part of the declaration contains semantic kadircet wrote:

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

hokein updated this revision to Diff 324616. hokein marked 4 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96944/new/ https://reviews.llvm.org/D96944 Files: clang/docs/Inte

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

sammccall accepted this revision. sammccall added reviewers: rsmith, kadircet. sammccall added a comment. This revision is now accepted and ready to land. I've reviewed this previously and am happy with how it ended up. But Kadir's comments are good, and we should also wait a few days in case oth

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

kadircet added a comment. thanks! i think this mostly looks great, leaving a couple of suggestions and questions in comments. Comment at: clang/docs/InternalsManual.rst:1882 + example. +- representing invalid node: the invalid node is preserved in the AST in some + form, e.g

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Hopefully it would be useful for new developers. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96944 Files: clang/docs/InternalsManual.