[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

steakhal added a comment. In D96905#2574398 , @steakhal wrote: > You could call it like `c-index-getCursor-fixed-point.c`. Hmm, to be honest, this was probably not what you wanted to test. What about simply inserting your own use-case which uncovered this

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM. In D96905#2574322 , @vabridgers wrote: > Polite ping. This is a small and simple change, my only doubt is the test > coverage. But frankly I

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

vabridgers added a comment. Polite ping. This is a small and simple change, my only doubt is the test coverage. But frankly I see none of the literals are covered in any of the test cases (unless I'm missing something). Could I get some guidance on required test coverage for this simple change,

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

vabridgers updated this revision to Diff 324473. vabridgers added a comment. Remove extraneous line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96905/new/ https://reviews.llvm.org/D96905 Files: clang/bindings/python/clang/cindex.py clang/bin