This revision was automatically updated to reflect the committed changes.
Closed by commit rG2d9cfcfef029: [clangd] Narrow and document a loophole in
blockUntilIdle (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96856/new/
ht
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96856/new/
https://reviews.llvm.org/D96856
sammccall added a comment.
Doh, sorry about the garbled patch
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:893
+ for (llvm::Optional Timeout :
+ {TimeoutSeconds, TimeoutSeconds, llvm::Optional(0)}) {
+if (!CDB.blockUntilIdle(timeoutSeconds(Timeout)))
---
sammccall updated this revision to Diff 324609.
sammccall added a comment.
Revert unintended changes, add FIXME
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96856/new/
https://reviews.llvm.org/D96856
Files:
clang-tools-extra/clangd/ClangdServer
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:893
+ for (llvm::Optional Timeout :
+ {TimeoutSeconds, TimeoutSeconds, llvm::Optional(0)}) {
+if (!CDB.blockUntilIdle(timeoutSeconds(Timeout)))
this is extending the
kadircet added a comment.
LG for the `blockUntilIdle` update, but feels like two patches wind up together
:(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96856/new/
https://reviews.llvm.org/D96856
___
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
blockUntilIdle of a parent can't always b
