[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f173c0c42d0: [clang][AVR] Support variable decorator '__flash' (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D96853?vs=334336&id=336593#toc Repository: rG LLVM Github Mo

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 ___ cfe-commits mailing list cfe-comm

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked an inline comment as done. benshi001 added a comment. In D96853#2661168 , @Anastasia wrote: > In D96853#2660443 , @benshi001 wrote: > >> In D96853#2659266 ,

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:159 +def err_verify_nonconst_addrspace : Error< + "qualifier 'const' is needed for variables in address space '%0'">;

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:159 +def err_verify_nonconst_addrspace : Error< + "qualifier 'const' is needed for variables in address space '%0'">; Ok, do you plan to pass anything other than

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. In D96853#2660443 , @benshi001 wrote: > In D96853#2659266 , @Anastasia wrote: > >> Btw is any pointer conversion between address space 1 and the default >> address space allowed? I.e. is

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 334336. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked 3 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + benshi001 wrote: > Anastasia wrote: > > If you are only checking the diagnostics

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 334330. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + Anastasia wrote: > If you are only checking the diagnostics you should pass: > > `-emit-llvm-only` -> `-syntax-only` > > a

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. Btw is any pointer conversion between address space 1 and the default address space allowed? I.e. is the following code valid: __flash static const int var1[] = {111, 222, 333}; void foo(int*); foo(var1); or __flash static const int var1[] = {111, 222,

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 333659. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. > I am guessing this will only be supported by 1 target in clang? Then target > address spaces make sense otherwise you can also extend the language address > space enum. Are you also planning to add `__flashN`? > https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spa

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. In D96853#2577172 , @benshi001 wrote: > In D96853#2577133 , @aykevl wrote: > >> I am not very familiar with Clang so I can't say much about it. Although I >> wonder whether a macro is the

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. fixes https://bugs.llvm.org/show_bug.cgi?id=31568 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 327361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 325286. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 325285. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2577133 , @aykevl wrote: > I am not very familiar with Clang so I can't say much about it. Although I > wonder whether a macro is the right way to implement this? Is there something > similar in other targets? (GPUs t

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

aykevl added a comment. I am not very familiar with Clang so I can't say much about it. Although I wonder whether the macro is the right way to implement this? Is there something similar in other targets? (GPUs tend to have lots of address spaces, you could take a look there). ==

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. This patch immitates avr-gcc behavior on `__flash` 1. `__flash` variables are put into `.section .progmem.data` 2. `__flash` non-const variables are rejected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ http

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96853