[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis updated this revision to Diff 324311. joechrisellis added a comment. This revision is now accepted and ready to land. Use __inline__ instead of inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96852/new/ https://reviews.llvm.org/

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

paulwalker-arm added a comment. One observation is that for arm_neon.h `__inline__` is used. So perhaps we can just do likewise and we'll also be consistent across the two ACLE headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96852/new/ htt

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis added a comment. > That makes sense and suggests we're missing some additional C++ testing? Agreed -- this passes all tests at the moment, so we can do better test-wise. The error to do with the one definition rule would crop up at link time, though, so we'd need at least two comp

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

tschuett added a comment. See __STDC_VERSION__ in https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96852/new/ https://reviews.llvm.org/D96852 __

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

paulwalker-arm added a comment. In D96852#2568383 , @joechrisellis wrote: > Speaking to @DavidTruby about this, it appears that this fix is insufficient > -- `inline` has important semantic meaning in C++ that means that we can't > simply omit the keywo

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis planned changes to this revision. joechrisellis added a comment. Speaking to @DavidTruby about this, it appears that this fix is insufficient -- `inline` has important semantic meaning in C++ that means that we can't simply omit the keyword here. The `inline` keyword bypasses the

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis created this revision. joechrisellis added reviewers: DavidTruby, peterwaller-arm, paulwalker-arm, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Her