[PATCH] D96847: [clang][cli] Store additional optimization remarks info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa25e4a6da3fe: [clang][cli] Store additional optimization remarks info (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. In D96847#2576369 , @dexonsmith wrote: > In D96847#2574408 , @jansvoboda11 > wrote: > >> That's a bit nicer. >> >> Not sure if `RemarkPattern` is a good name now, as it may represent a

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 325408. jansvoboda11 added a comment. Comment wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang/include/clang/Basic/CodeGenOptions.h clang/

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 325407. jansvoboda11 added a comment. Rename `RemarkPattern` to `OptRemark`, simplify the API usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith added a comment. In D96847#2574408 , @jansvoboda11 wrote: > That's a bit nicer. > > Not sure if `RemarkPattern` is a good name now, as it may represent an > optimization remark that doesn't have any pattern associated with it. > How about call

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. That's a bit nicer. Not sure if `RemarkPattern` is a good name now, as it may represent an optimization remark that doesn't have any pattern associated with it. How about calling it `OptimizationRemark` and merging `operator bool` and `operator ->` into `bool patte

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 324956. jansvoboda11 added a comment. Put `RemarkKind` in `RemarkPattern`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang/include/clang/Basic/CodeG

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:306-307 + // The kind of optimization remark argument on the command line. + RemarkKind OptimizationRemarkKind; /// Regular expression to select optimizations for which we should enabl

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 324225. jansvoboda11 added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang/include/clang/Basic/CodeGenOptions.h clang/l

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After a revision of D96274 changed `DiagnosticOptions`