This revision was automatically updated to reflect the committed changes.
Closed by commit rG5f7715d8780a: Pass the cmdline aapcs bitfield options to cc1
(authored by stuij).
Changed prior to commit:
https://reviews.llvm.org/D96784?vs=324589&id=324631#toc
Repository:
rG LLVM Github Monorepo
DavidSpickett added a comment.
LGTM with /// for the comments in the test.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525
+void AddAAPCSVolatileBitfieldArgs(const ArgList &Args, ArgStringList &CmdArgs)
{
+ if (!Args.hasFlag(options::OPT_faapcs_bitfield_width,
--
stuij added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525
+void AddAAPCSVolatileBitfieldArgs(const ArgList &Args, ArgStringList &CmdArgs)
{
+ if (!Args.hasFlag(options::OPT_faapcs_bitfield_width,
DavidSpickett wrote:
> Name this AddA
stuij updated this revision to Diff 324589.
stuij added a comment.
added unit tests for the cmdline args
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96784/new/
https://reviews.llvm.org/D96784
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clan
DavidSpickett added a comment.
Looks ok but needs tests. See clang/test/Driver for examples of checking -###
output.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525
+void AddAAPCSVolatileBitfieldArgs(const ArgList &Args, ArgStringList &CmdArgs)
{
+ if (!Args.hasFlag
stuij created this revision.
Herald added a subscriber: kristof.beyls.
stuij requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The following commits added commandline arguments to control following the Arm
Procedure Call Standard for certain
