This revision was automatically updated to reflect the committed changes.
Closed by commit rGe7e67c930ae5: Add Windows ehcont section support
(/guard:ehcont). (authored by pengfei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96709/new/
https://re
rnk added inline comments.
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499
CmdArgs.push_back("-guard:cf-");
+} else if (GuardArgs.equals_lower("ehcont")) {
+ CmdArgs.push_back("/guard:ehcont");
pengfei wrote:
> rnk wrote:
> > This is gone now
pengfei added a comment.
Thanks for the review.
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499
CmdArgs.push_back("-guard:cf-");
+} else if (GuardArgs.equals_lower("ehcont")) {
+ CmdArgs.push_back("/guard:ehcont");
rnk wrote:
> This is gone
pengfei updated this revision to Diff 327654.
pengfei added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96709/new/
https://reviews.llvm.org/D96709
Files:
clang/docs/UsersManual.rst
clang/include/clang/Basic/CodeGenOptions
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499
CmdArgs.push_back("-guard:cf-");
+} else if (GuardArgs.equals_lower("ehcont")) {
+ CmdArgs.push_back("/guar
pengfei created this revision.
pengfei added reviewers: arlosi, rnk, thakis, ajpaverd, theraven, pcc.
Herald added subscribers: dexonsmith, dang.
Herald added a reviewer: jansvoboda11.
pengfei requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-comm
