[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. In D96665#2579422 , @steveire wrote: > In D96665#2578635 , @goncharov wrote: > >> Hi @steveire! Sorry but I reverted this revert. Could you please give some >> context of "discussed elsewh

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. In D96665#2578635 , @goncharov wrote: > Hi @steveire! Sorry but I reverted this revert. Could you please give some > context of "discussed elsewhere" and "pre-existing unit test for the > matcher"? @aaron.ballman for cc @njames

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. In D96665#2578718 , @goncharov wrote: > I have relanded this in > https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d > . My apologies @goncharov Why did you revert this change? Repository:

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

goncharov added a comment. I have relanded this in https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d . My apologies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665 _

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

goncharov added a comment. Hi @steveire! Sorry but I reverted this revert. Could you please give some context of "discussed elsewhere" and "pre-existing unit test for the matcher"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://r

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

This revision was automatically updated to reflect the committed changes. Closed by commit rG6984e0d43985: Revert "Implement nullPointerConstant() using a better API." (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/ne

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. As discussed elsewhere, the bots are not broken. The changes reverted here were made in 2019. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665 _

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

njames93 added a comment. I'm a little confused here, Typically if a commit is breaking bots a review doesn't need to be opened to revert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665 ___

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 9148302a (2019-08-22) which broke the pre-existing unit test for the matcher. A