This revision was automatically updated to reflect the committed changes.
Closed by commit rGee4dd0f87698: [clangd] Remove the cross-file-rename option.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96578/new/
https://reviews.l
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:237
-IsMainFileOnly = false;
- // If the symbol is not indexable, we disallow rename.
- if (!SymbolCollector::shouldCollectSymbol(
sammccall wrote:
> I don't understand w
hokein updated this revision to Diff 323250.
hokein marked an inline comment as done.
hokein added a comment.
address review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96578/new/
https://reviews.llvm.org/D96578
Files:
clang-tools-ext
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:405
+// prepareRename is latency-sensitive: we deliberately pass a nullptr index
+// to save the cost, thus the result may be incomplete as it only contains
+// main-file occurrence
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang.
and simplify the code.
Repository:
rG LLVM Githu
