[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2578765 , @thakis wrote: > In D96515#2578666 , @Anastasia wrote: > >> In D96515#2578629 , @thakis wrote: >> >>> Looks like this breaks te

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

thakis added a comment. In D96515#2578666 , @Anastasia wrote: > In D96515#2578629 , @thakis wrote: > >> Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt >> >> Please take a look, and revert fo

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a subscriber: klimek. Anastasia added a comment. In D96515#2578666 , @Anastasia wrote: > In D96515#2578629 , @thakis wrote: > >> Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.tx

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2578629 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for pointing this out. I think the follow

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/ https://reviews.llvm.org/D9

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3ef15a6ec5: [OpenCL] Add builtin declarations by default. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/ https://reviews.llvm.org/D96515 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2560280 , @Anastasia wrote: > In D96515#2559424 , @svenvh wrote: > >> It probably makes sense to update `clang/docs/UsersManual.rst` as part of >> this change. In particular th

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2559424 , @svenvh wrote: > It probably makes sense to update `clang/docs/UsersManual.rst` as part of > this change. In particular the following sentence is no longer true after > this patch: "By default the OpenCL he

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia updated this revision to Diff 323362. Anastasia added a comment. Changed command line option text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/ https://reviews.llvm.org/D96515 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/Types.h cl

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

svenvh added a comment. It probably makes sense to update `clang/docs/UsersManual.rst` as part of this change. In particular the following sentence is no longer true after this patch: "By default the OpenCL headers are not loaded and therefore certain builtin types and most of builtin function

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia created this revision. Anastasia added reviewers: svenvh, arsenm. Herald added subscribers: dang, ebevhan, yaxunl. Herald added a reviewer: jansvoboda11. Anastasia requested review of this revision. Herald added a subscriber: wdng. See original RFC: https://lists.llvm.org/pipermail/cfe-