[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

2021-02-13 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG022920c25b8e: [clangd] Retire clang-tidy-checks flag. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D96508?vs=323011&id=323553#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

2021-02-12 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D96508#2559936 , @sammccall wrote: > I think we should have the config mechanism available for one release cycle > before removing the old one. > > So I think it's fine to retire the flag but we shouldn't pick this into the >

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

2021-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think we should have the config mechanism available for one release cycle before removing the old one. So I think it's fine to retire the flag but we shouldn't pick this into the 12

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

2021-02-12 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Ping? It would be nice to get this fix in the release branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96508/new/ https://reviews.llvm.org/D96508 ___ cfe-commits mailing li

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

2021-02-11 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. In clangd-12 the ability to overr