thakis added a comment.
Looks like this doesn't build on Windows:
http://45.33.8.238/win/33161/step_4.txt (clang-cl + msvc stdlib)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96507/new/
https://reviews.llvm.org/D96507
__
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked 3 inline comments as done.
Closed by commit rGcea9f054327b: [clangd] Move command handlers into a map in
ClangdLSPServer. NFC (authored by sammccall).
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:587
+ std::vector Commands;
+ llvm::copy(CommandHandlers.keys(), std::back_inserter(Commands));
+
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, mgrang.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Mono
