[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

2021-02-11 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG573348ab9b28: [clangd] Retire the cross-file-rename command-line flag. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

2021-02-11 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 323084. hokein added a comment. fix failure tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96495/new/ https://reviews.llvm.org/D96495 Files: clang-tools-extra/clangd/refactor/Rename.h clang-tools-extr

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

2021-02-11 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D96495#2556897 , @njames93 wrote: > Those test failures look related. oh, right. the failure tests rely on the default cross-file flag, fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

2021-02-11 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Those test failures look related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96495/new/ https://reviews.llvm.org/D96495 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

2021-02-11 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. This patch only focuses on the flag. Removing actual