Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

2015-08-27 Thread Philippe Daouadi via cfe-commits
blastrock added a comment. Thank you! http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

2015-08-27 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. r246168 http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

2015-08-27 Thread Philippe Daouadi via cfe-commits
blastrock added a comment. Oh I see! Indeed, I don't have commit rights, so I would help me if you could do it :) http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

2015-08-27 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. Ah, usually the process is that you get your patch through review, and when someone accepts it, then you can commit it. If you do not have commit rights, then you can get someone else to commit it for you. Accepted => "ok to commit" Closed => "I've committed it" Do yo

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

2015-08-27 Thread Philippe Daouadi via cfe-commits
blastrock added a comment. Sorry, I'm not sure I got what is the workflow on this platform. This patch is now "accepted", but do I need to do something else here? The only relevant action I can do seems to be "close revision", should I do that? The developper policy page

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

2015-08-27 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. @blastrock have you committed this yet? http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits