[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy added a comment. In D96354#2566511 , @dblaikie wrote: > In D96354#2566502 , @hoy wrote: > >> In D96354#2554129 , @probinson >> wrote: >> the driver had a redundant

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

dblaikie added a comment. In D96354#2566502 , @hoy wrote: > In D96354#2554129 , @probinson wrote: > >>> the driver had a redundant pass-through of the option >> >> I could've sworn it worked to remove that, but it d

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy added a comment. In D96354#2554129 , @probinson wrote: >> the driver had a redundant pass-through of the option > > I could've sworn it worked to remove that, but it didn't when I rebased, so > that's gone from the final patch (i.e, the explicit pass-

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

dblaikie added a comment. @hoy Could you explain a bit further why these two features are incompatible/what the crash looks like? At first glance I wouldn't expect any debug info mode to be incompatible with any non-debug-info mode (maybe less useful, but not crashy levels of incompatible). R

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

probinson added a comment. > the driver had a redundant pass-through of the option I could've sworn it worked to remove that, but it didn't when I rebased, so that's gone from the final patch (i.e, the explicit pass-through in the driver is still there). It's a functionally separate topic anyw

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea2d4fa4811: Avoid conflicts between debug-info and pseudo-probe profiling (authored by probinson). Changed prior to commit: https://reviews.llvm

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. Thanks for fixing these issues! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96354/new/ https://reviews.llvm.org/D96354 __

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

probinson created this revision. probinson added reviewers: hoy, wmi. probinson requested review of this revision. Herald added a project: clang. After D93264 , using both -fdebug-info-for-profiling and -fpseudo-probe-for-profiling will cause the compiler to cras