njames93 added a comment.
Herald added a project: clang-tools-extra.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96286/new/
https://reviews.llvm.org/D96286
___
cfe-commits mailing list
cfe-commits
kadircet added a comment.
just wanted to point out that, this is almost the same thing as
https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/GlobalCompilationDatabase.cpp#L569.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D9628
njames93 added a comment.
Ping @sammccall Any issues with this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96286/new/
https://reviews.llvm.org/D96286
___
cfe-commits mailing list
cfe-commits@lists.llv
njames93 updated this revision to Diff 325266.
njames93 added a comment.
Update using absoluteParent helper
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96286/new/
https://reviews.llvm.org/D96286
Files:
clang-tools-extra/clangd/TidyProvider.cpp
njames93 added a comment.
A similar approach could be used for the config provider, however It may not
make as much sense there. The directories are traversed in the opposite order
and we will always attempt to read from each directory.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
njames93 created this revision.
njames93 added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
I know linked lists are the work