jansvoboda11 updated this revision to Diff 322310.
jansvoboda11 added a comment.
Replace commented-out code with reason behind not generating arguments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96280/new/
https://reviews.llvm.org/D96280
Files:
dexonsmith added a comment.
Mostly looks great; happy to see this come full circle and remove the
round-tripping boilerplate. Just a couple of questions inline below.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1940-1941
case EDK_ProfileList:
- GenerateArg(
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Finally, this patch moves from round-tripping one `CompilerInvocation` at a
time to round