[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb581fc32411: [clang][cli] Generate and round-trip Diagnostic options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.or

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! In D96274#2551206 , @probinson wrote: > I don't claim to be very familiar with this area but "round-trip" and "test" > would make me thi

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

probinson added a comment. I don't claim to be very familiar with this area but "round-trip" and "test" would make me think those bits should be in a lit test or unittest. As it is, it's not obvious what is functional and what is testing here. Possibly I am misunderstanding something fundamental

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 added a comment. Got rid of `{Warnings,Remarks}AsWritten` entirely. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:745 + +A->render(Args, Rendered); } dexonsmith wrote: > It's not obvious why this renders the args instead of calling

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 updated this revision to Diff 322365. jansvoboda11 added a comment. Remove the need for {Warnings,Remarks}AsWritten field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96274/new/ https://reviews.llvm.org/D96274 Files: clang/include/

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:745 + +A->render(Args, Rendered); } It's not obvious why this renders the

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining diagnostic