This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd1522d349f4d: [-Wcompletion-handler] Support checks with
builtins (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
vsavchenko added inline comments.
Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:343
+case Builtin::BI__builtin_expect_with_probability: {
+ assert(CE->getNumArgs() >= 2);
+
NoQ wrote:
> Otherwise it's a compile error and analysis based warnings aren
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Aha, yup, makes sense!
Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:343
+case Builtin::BI__builtin_expect_with_probability: {
+ assert(CE->getNumArgs() >= 2);
+
vsavchenko created this revision.
vsavchenko added a reviewer: NoQ.
Herald added a subscriber: Charusso.
vsavchenko requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
It is very common to check callbacks and completion handlers for null.
This
