[PATCH] D96244: [clangd][RFC] Introudce Plugins

2021-02-10 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 322744. kadircet added a comment. - Rename Plugin to Module - Have a ModuleSet that enables type-safe traversal of existing modules (with questions about implementation options) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D96244: [clangd][RFC] Introudce Plugins

2021-02-08 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/Plugin.h:26 + virtual llvm::Optional + actOnDiagnostic(DiagnosticsEngine::Level L, const clang::Diagnostic &Diag) { +return llvm::None; i think it would be better to have these as separate

[PATCH] D96244: [clangd][RFC] Introudce Plugins

2021-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. Herald added subscribers: usaxena95, arphaman, mgorny. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Plugins can be used to augment clangd's behaviours in various features. I