[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire added a comment. Thanks for the heads-up. I've reverted it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224 ___ cfe-commits mailing list cfe-commits@

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

ymandel added a comment. In D96224#2581501 , @njames93 wrote: > Can you take a look at https://llvm.org/PR49330, I'm guessing this patch > introduced this regression. +1 We've had to disable the check in the meantime. Repository: rG LLVM Github Monor

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

njames93 added a comment. Can you take a look at https://llvm.org/PR49330, I'm guessing this patch introduced this regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224 __

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a4b574dd6a0: [clang-itdy] Simplify virtual near-miss check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://rev

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Fair enough, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224 ___

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire added a comment. > What happens when TBase is an explicit specialization. It's not changed before or after this patch. This check is documented as changing code based on the derived classes based on typos of methods overridden from the base. Your suggestion makes sense to me, but it i

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire updated this revision to Diff 325232. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224 Files: clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp clan

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

njames93 added a comment. What happens when TBase is an explicit specialization. In that situation a warning for the explicit specialization may be useful. template <> struct TBase { virtual void tfunt(T t); }; Comment at: clang-tools-extra/test/clang-tidy/checkers/b

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added a subscriber: nullptr.cpp. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Diagnose the problem in templates in the context of the temp