[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

2021-02-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D96215#2550227 , @NoQ wrote: > In D96215#2548492 , @aaron.ballman > wrote: > >> Should structured bindings be treated similarly as well (not necessarily as >> part of this patch)?

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

2021-02-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D96215#2548492 , @aaron.ballman wrote: > Should structured bindings be treated similarly as well (not necessarily as > part of this patch)? Umm, looks like we're both missing the elephant in the room: passing a variable into a f

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

2021-02-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Notionally, I think it makes sense to treat byref captures as a form of aliasing. Should structured bindings be treated similarly as well (not necessarily as part of this patch)? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

2021-02-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, vsavchenko. Herald added subscribers: nullptr.cpp, martong, mgehre, Charusso, xazax.hun. NoQ requested review of this revision. The utility function `clang::tidy::utils::`()` scans the function for pointer/referenc