This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3ce7f5cd2ae: [HIP] Fix managed variable linkage (authored
by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96195/new
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGCUDARuntime.h:107
+ /// Transform managed variables in device compilation.
+ virtual void transformManagedVars() = 0;
};
yax
yaxunl updated this revision to Diff 324971.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
refactor CGCUDARuntime interface not to expose transformManagedVar.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96195/new/
https://reviews.llvm.org/D96195
Files:
clang/lib/
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1017
+
+void CGNVCUDARuntime::transformManagedVars() {
+ for (auto &&Info : DeviceVars) {
tra wrote:
> A comment about how exactly we're transformin
tra added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1017
+
+void CGNVCUDARuntime::transformManagedVars() {
+ for (auto &&Info : DeviceVars) {
A comment about how exactly we're transforming the vars would be helpful.
Comment a
yaxunl updated this revision to Diff 324806.
yaxunl added a comment.
keep managed var in llvm.compiler.used since they need runtime handling even if
they are not used in device code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96195/new/
https://reviews.llvm.org/D96195
Files:
clan
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96195/new/
https://reviews.llvm.org/D96195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: dexonsmith, hiraditya.
yaxunl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Currently managed variables are emitted as undefined symbols, which
causes d
