This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5e8a246ac996: [clang][cli] Generate and round-trip Frontend
options (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/
jansvoboda11 added a comment.
Thanks, a copy-paste mistake.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96155/new/
https://reviews.llvm.org/D96155
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, although the description seems incorrect:
> This patch implements generation of remaining preprocessor options and tests
> it by performing parse-generate-parse round trip.
In f
jansvoboda11 added inline comments.
Comment at: clang/include/clang/Serialization/ModuleFileExtension.h:75
+ ModuleFileExtensionKind getKind() const { return Kind; }
+
I'm not sure what the best approach is here.
`ModuleFileExtension` is an abstract class. Wh
jansvoboda11 updated this revision to Diff 322121.
jansvoboda11 added a comment.
Fix whitespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96155/new/
https://reviews.llvm.org/D96155
Files:
clang/include/clang/Driver/Options.td
clang/include
jansvoboda11 updated this revision to Diff 322120.
jansvoboda11 added a comment.
Document getProgramActionOpt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96155/new/
https://reviews.llvm.org/D96155
Files:
clang/include/clang/Driver/Options.td
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch implements generation of remaining preprocesso
